Issue 9704049: Add another language test for initializer ordering.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9704049: Add another language test for initializer ordering. (Closed)

Created:
8 years, 9 months ago by sra1

Modified:
8 years, 9 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add another language test for initializer ordering. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=5538

Patch Set 1 : #

Total comments: 1

Patch Set 2 : remove += #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -0 lines)			Patch
	M	tests/language/language.status	View		1 chunk	+1 line, -0 lines	0 comments	Download
	A	tests/language/src/Constructor7Test.dart	View	1	1 chunk	+62 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kasperl

8 years, 9 months ago (2012-03-15 10:31:13 UTC) #2

LGTM if you stop using + for string concat.

https://chromiumcodereview.appspot.com/9704049/diff/5001/tests/language/src/C...
File tests/language/src/Constructor7Test.dart (right):

https://chromiumcodereview.appspot.com/9704049/diff/5001/tests/language/src/C...
tests/language/src/Constructor7Test.dart:11: String trace = "";
Replace this with a StringBuffer or use trace = trace.concat in E.

Expand Messages | Collapse Messages