Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 9704037: Another fix for non-mac build: (Closed)

Created:
8 years, 9 months ago by turnidge
Modified:
8 years, 9 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Another fix for non-mac build: ../runtime/platform/assert.h: In member function ‘void dart::DynamicAssertionHelper::Equals(const E&, const A&) [with E = int, A = uint64_t]’: ../runtime/vm/thread_pool_test.cc:64: instantiated from here ../runtime/platform/assert.h:98: error: comparison between signed and unsigned integer expressions Committed: https://code.google.com/p/dart/source/detail?r=5486

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M runtime/vm/thread_pool_test.cc View 3 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
turnidge
TBR=iposva
8 years, 9 months ago (2012-03-14 21:10:04 UTC) #1
Ivan Posva
8 years, 9 months ago (2012-03-15 00:43:15 UTC) #2
Please see the comment in the original thread pool change. But this change
should not have been needed, if I had paid better attention during your review.

-Ivan

Powered by Google App Engine
This is Rietveld 408576698