Issue 9704024: Update dart:dom and dart:html bindings to reflect latest webkit changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9704024: Update dart:dom and dart:html bindings to reflect latest webkit changes. (Closed)

Created:
8 years, 9 months ago by Jacob

Modified:
8 years, 9 months ago

Reviewers:
nweiz, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update dart:dom and dart:html bindings to reflect latest webkit changes. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=5493

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1179 lines, -416 lines)			Patch
M	client/dom/dom.dart	View	6 chunks	+187 lines, -59 lines	0 comments	Download
M	client/dom/frog/dom_frog.dart	View	11 chunks	+311 lines, -106 lines	0 comments	Download
M	client/html/dartium/html_dartium.dart	View	15 chunks	+370 lines, -145 lines	0 comments	Download
M	client/html/frog/html_frog.dart	View	12 chunks	+311 lines, -106 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jacob

I'm not a huge fan of these changes. Do we have to leave class with ...

8 years, 9 months ago (2012-03-14 18:42:06 UTC) #1

nweiz

lgtm, although I vote that we just remove everything marked as deprecated. It's not like ...

8 years, 9 months ago (2012-03-14 19:42:23 UTC) #2

Jacob

8 years, 9 months ago (2012-03-14 22:19:59 UTC) #3

Filed a bug for SpeechGrammarList
http://code.google.com/p/dart/issues/detail?id=2174

For the obsolete class after discussing with Sra, we will just wait as it is
likely going away from WebKit in a bit anyway.

Expand Messages | Collapse Messages