Issue 9704009: Support parsing HTTP responses where the body length is not known

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9704009: Support parsing HTTP responses where the body length is not known (Closed)

Created:
8 years, 9 months ago by Søren Gjesse

Modified:
8 years, 9 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support parsing HTTP responses where the body length is not known The HTTP parser ends the body when the connection is closed. This only implements this in the HTTP parser - it is not yet used in the dart:io HTTP library. R=ajohnsen@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=5641

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comments #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+116 lines, -39 lines)			Patch
	M	runtime/bin/http_parser.dart	View	1	9 chunks	+39 lines, -16 lines	0 comments	Download
	M	tests/standalone/src/io/HttpParserTest.dart	View		14 chunks	+77 lines, -23 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

LGTM, very cool. I think this will help solve many of the problems I've encountered! ...

8 years, 9 months ago (2012-03-15 11:24:04 UTC) #2

Søren Gjesse

8 years, 9 months ago (2012-03-19 11:31:48 UTC) #3

http://codereview.chromium.org/9704009/diff/1/runtime/bin/http_parser.dart
File runtime/bin/http_parser.dart (right):

http://codereview.chromium.org/9704009/diff/1/runtime/bin/http_parser.dart#ne...
runtime/bin/http_parser.dart:337: if (_remainingContent != null &&
_remainingContent == 0) {
On 2012/03/15 11:24:04, ajohnsen wrote:
> == 0 should be sufficient.

Done.

Expand Messages | Collapse Messages