Fix some minor static type issues in dart:io implementation.

Fix some minor static type issues in dart:io implementation.


BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=5514

[Bill Hesse, 2012-03-14 13:24:57]

A minor change.

https://chromiumcodereview.appspot.com/9703023/diff/1/runtime/bin/socket_impl...
File runtime/bin/socket_impl.dart (right):

https://chromiumcodereview.appspot.com/9703023/diff/1/runtime/bin/socket_impl...
runtime/bin/socket_impl.dart:210: bool _closedWrite = false;
Various methods in _SocketBase use these fields, so they should be in
_SocketBase.

[Mads Ager (google), 2012-03-14 13:34:07]

https://chromiumcodereview.appspot.com/9703023/diff/1/runtime/bin/file_impl.dart
File runtime/bin/file_impl.dart (right):

https://chromiumcodereview.appspot.com/9703023/diff/1/runtime/bin/file_impl.d...
runtime/bin/file_impl.dart:492: RandomAccessFile openSync(FileMode mode) {
Why?

I can't believe that this does not break other code. If you really want to make
this change you need to find all users and update the API as well.

https://chromiumcodereview.appspot.com/9703023/diff/1/runtime/bin/process_imp...
File runtime/bin/process_impl.dart (right):

https://chromiumcodereview.appspot.com/9703023/diff/1/runtime/bin/process_imp...
runtime/bin/process_impl.dart:200: _Socket _in;  // Private methods of _Socket
are used.
This is not just a comment on this line. move to a separate line above?

https://chromiumcodereview.appspot.com/9703023/diff/1/runtime/bin/socket_impl...
File runtime/bin/socket_impl.dart (right):

https://chromiumcodereview.appspot.com/9703023/diff/1/runtime/bin/socket_impl...
runtime/bin/socket_impl.dart:288: bool get closed() => _closedWrite &&
_closedRead;
It looks to me like this should be deleted instead.

closed is not part of the Socket interface and i don't see uses of it, at least
not here?

[Bill Hesse, 2012-03-14 13:46:49]

https://chromiumcodereview.appspot.com/9703023/diff/1/runtime/bin/file_impl.dart
File runtime/bin/file_impl.dart (right):

https://chromiumcodereview.appspot.com/9703023/diff/1/runtime/bin/file_impl.d...
runtime/bin/file_impl.dart:492: RandomAccessFile openSync(FileMode mode) {
The File interface already declares openSync this way.
This is just an implementation (in _File) with declaration disagreeing with the
interface.  All users of this go through the File interface, which has the
non-optional argument already. 

On 2012/03/14 13:34:08, Mads Ager wrote:
> Why?
> 
> I can't believe that this does not break other code. If you really want to
make
> this change you need to find all users and update the API as well.

https://chromiumcodereview.appspot.com/9703023/diff/1/runtime/bin/process_imp...
File runtime/bin/process_impl.dart (right):

https://chromiumcodereview.appspot.com/9703023/diff/1/runtime/bin/process_imp...
runtime/bin/process_impl.dart:200: _Socket _in;  // Private methods of _Socket
are used.
On 2012/03/14 13:34:08, Mads Ager wrote:
> This is not just a comment on this line. move to a separate line above?

Done.

https://chromiumcodereview.appspot.com/9703023/diff/1/runtime/bin/socket_impl...
File runtime/bin/socket_impl.dart (right):

https://chromiumcodereview.appspot.com/9703023/diff/1/runtime/bin/socket_impl...
runtime/bin/socket_impl.dart:288: bool get closed() => _closedWrite &&
_closedRead;
Deleted.  Not surprising it didn't fail, since it was never called.

On 2012/03/14 13:34:08, Mads Ager wrote:
> It looks to me like this should be deleted instead.
> 
> closed is not part of the Socket interface and i don't see uses of it, at
least
> not here?

[Mads Ager (google), 2012-03-14 14:03:03]

https://chromiumcodereview.appspot.com/9703023/diff/1/runtime/bin/file_impl.dart
File runtime/bin/file_impl.dart (right):

https://chromiumcodereview.appspot.com/9703023/diff/1/runtime/bin/file_impl.d...
runtime/bin/file_impl.dart:492: RandomAccessFile openSync(FileMode mode) {
On 2012/03/14 13:46:49, Bill Hesse wrote:
> The File interface already declares openSync this way.
> This is just an implementation (in _File) with declaration disagreeing with
the
> interface.  All users of this go through the File interface, which has the
> non-optional argument already. 
> 
> On 2012/03/14 13:34:08, Mads Ager wrote:
> > Why?
> > 
> > I can't believe that this does not break other code. If you really want to
> make
> > this change you need to find all users and update the API as well.
> 

OK, could you check that all users of openSync provide a mode. If they don't
this change will still break users.

[Bill Hesse, 2012-03-14 15:32:42]

https://chromiumcodereview.appspot.com/9703023/diff/4002/runtime/bin/file_imp...
File runtime/bin/file_impl.dart (right):

https://chromiumcodereview.appspot.com/9703023/diff/4002/runtime/bin/file_imp...
runtime/bin/file_impl.dart:492: RandomAccessFile openSync(FileMode mode) {
Removed.

The openSync() method is called with no arguments at about 30 spots, scattered
throughout the Dart code base.  These must all be changed, if we make the mode
argument non-optional.  This should be done in a separate change, if at all.

[Mads Ager (google), 2012-03-15 08:22:52]

lgtm