Issue 9701072: Revert r5529. Breaks frog and web bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9701072: Revert r5529. Breaks frog and web bots. (Closed)

Created:
8 years, 9 months ago by Emily Fortuna

Modified:
8 years, 9 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Revert r5529. Breaks frog and web bots. Committed: https://code.google.com/p/dart/source/detail?r=5532

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -98 lines)			Patch
M	frog/leg/compile_time_constants.dart	View	3 chunks	+30 lines, -15 lines	0 comments	Download
M	frog/leg/resolver.dart	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	frog/leg/universe.dart	View	3 chunks	+6 lines, -7 lines	0 comments	Download
M	frog/leg/warnings.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/co19/co19-leg.status	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	tests/language/language-leg.status	View	2 chunks	+2 lines, -0 lines	0 comments	Download
D	tests/language/src/CompileTimeConstantETest.dart	View	1 chunk	+0 lines, -70 lines	0 comments	Download

Total messages: 2 (0 generated)

floitsch

8 years, 9 months ago (2012-03-17 21:28:28 UTC) #2

LGTM.
You could have also just marked the new test as failing in the status files.