Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 9701054: - Proper inclusion of gypi files, so that they do not override (Closed)

Created:
8 years, 9 months ago by Ivan Posva
Modified:
8 years, 9 months ago
Reviewers:
turnidge, cshapiro
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

- Proper inclusion of gypi files, so that they do not override existing build flags. Committed: https://code.google.com/p/dart/source/detail?r=5505

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -34 lines) Patch
M third_party/double-conversion/src/double-conversion.gypi View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/jscre/jscre.gypi View 1 chunk +0 lines, -12 lines 0 comments Download
M vm/dart_api_impl_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M vm/token.h View 1 chunk +4 lines, -4 lines 0 comments Download
M vm/token.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ivan Posva
8 years, 9 months ago (2012-03-15 01:06:05 UTC) #1
cshapiro
lgtm
8 years, 9 months ago (2012-03-15 01:06:39 UTC) #2
turnidge
8 years, 9 months ago (2012-03-15 16:52:48 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698