Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 9701001: named optional parameters must not be private (Closed)

Created:
8 years, 9 months ago by hausner
Modified:
8 years, 9 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

named optional parameters must not be private Named optional parameters may not start with an underscore '_'. Fix issue 434 (http://code.google.com/p/dart/issues/detail?id=434) Committed: https://code.google.com/p/dart/source/detail?r=5444

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -13 lines) Patch
M corelib/src/exceptions.dart View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/parser.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 2 chunks +1 line, -1 line 0 comments Download
M tests/language/language.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/src/ParameterInitializerTest.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 4 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
hausner
8 years, 9 months ago (2012-03-13 23:05:40 UTC) #1
srdjan
8 years, 9 months ago (2012-03-13 23:19:40 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698