Use NodeElement to access Node in Resolver

Use NodeElement to access Node in Resolver

Note, that such access it type safe, because we return NodeElement from corresponding Node subclasses, return other NodeElements from NodeElement accessors, etc.

R=zundel@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=5471

[zundel, 2012-03-14 14:57:27]

lgtm, only nits

https://chromiumcodereview.appspot.com/9700019/diff/1/compiler/java/com/googl...
File compiler/java/com/google/dart/compiler/resolver/ConstructorNodeElement.java
(right):

https://chromiumcodereview.appspot.com/9700019/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/resolver/ConstructorNodeElement.java:9: *
Extension of {@link MethodElement} which is base of {@link DartNode}.
(Did you mean {@link ConstructorElement} ? this seems redundant with the class
declaration

https://chromiumcodereview.appspot.com/9700019/diff/1/compiler/java/com/googl...
File compiler/java/com/google/dart/compiler/resolver/MethodNodeElement.java
(right):

https://chromiumcodereview.appspot.com/9700019/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/resolver/MethodNodeElement.java:9: *
Extension of {@link MethodElement} which is base of {@link DartNode}.
this comment seems redundant with the class declaration.

[scheglov, 2012-03-14 15:20:50]

https://chromiumcodereview.appspot.com/9700019/diff/1/compiler/java/com/googl...
File compiler/java/com/google/dart/compiler/resolver/ConstructorNodeElement.java
(right):

https://chromiumcodereview.appspot.com/9700019/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/resolver/ConstructorNodeElement.java:9: *
Extension of {@link MethodElement} which is base of {@link DartNode}.
On 2012/03/14 14:57:27, zundel wrote:
> (Did you mean {@link ConstructorElement} ? this seems redundant with the class
> declaration 

Done.

https://chromiumcodereview.appspot.com/9700019/diff/1/compiler/java/com/googl...
File compiler/java/com/google/dart/compiler/resolver/MethodNodeElement.java
(right):

https://chromiumcodereview.appspot.com/9700019/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/resolver/MethodNodeElement.java:9: *
Extension of {@link MethodElement} which is base of {@link DartNode}.
On 2012/03/14 14:57:27, zundel wrote:
> this comment seems redundant with the class declaration.

I still prefer to have some comment, just because everything should have
comment.