Issue 9700016: Allow interpolated strings and adjacent strings to be compile-time constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9700016: Allow interpolated strings and adjacent strings to be compile-time constants. (Closed)

Created:
8 years, 9 months ago by kasperl

Modified:
8 years, 9 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org, Lasse Reichstein Nielsen, Ivan Posva

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Allow interpolated strings and adjacent strings to be compile-time constants. R=ngeoffray@google.com BUG=http://dartbug.com/2110,http://dartbug.com/2127 TEST= Committed: https://code.google.com/p/dart/source/detail?r=5461

Patch Set 1 #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+97 lines, -33 lines)			Patch
M	frog/analyze.dart	View	1 chunk	+10 lines, -16 lines	0 comments	Download
M	frog/gen.dart	View	2 chunks	+26 lines, -5 lines	1 comment	Download
M	frog/minfrog	View	6 chunks	+56 lines, -10 lines	0 comments	Download
M	frog/value.dart	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	tests/language/language.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

8 years, 9 months ago (2012-03-14 12:13:10 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/9700016/diff/1/frog/gen.dart
File frog/gen.dart (right):

https://chromiumcodereview.appspot.com/9700016/diff/1/frog/gen.dart#newcode2314
frog/gen.dart:2314: if (items.length == itemsConst.length) {
instead of having two lists, could you just have a boolean and a list? This will
change line 2311 to:
if (!val.isConst) isConst = false;

Expand Messages | Collapse Messages