Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 9699090: Make Throw and ReThrow instructions instead of computations. That way they can terminate a basic bl… (Closed)

Created:
8 years, 9 months ago by srdjan
Modified:
8 years, 9 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Make Throw and ReThrow instructions instead of computations. That way they can terminate a basic block. Committed: https://code.google.com/p/dart/source/detail?r=5539

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -103 lines) Patch
M runtime/vm/flow_graph_builder.cc View 1 2 4 chunks +29 lines, -24 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 2 2 chunks +22 lines, -19 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 2 6 chunks +69 lines, -60 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 2 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
srdjan
8 years, 9 months ago (2012-03-15 20:22:15 UTC) #1
Kevin Millikin (Google)
8 years, 9 months ago (2012-03-15 20:32:24 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698