Issue 9699032: Wrap all arguments passed to processes in "" on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9699032: Wrap all arguments passed to processes in "" on Windows. (Closed)

Created:
8 years, 9 months ago by Mads Ager (google)

Modified:
8 years, 9 months ago

Reviewers:
Anton Muhin, Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Wrap all arguments passed to processes in "" on Windows. I'm not 100% sure that this is what we want. I'll dig into what other systems are doing tomorrow. This could make the test scripts work on Windows for Dartium. Updated windows test binary as well. R=antonm@google.com,sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=5472

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	runtime/bin/process_win.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
	M	tools/testing/bin/windows/dart.exe	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages