Issue 9699030: Use NodeElement in SupertypeResolver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9699030: Use NodeElement in SupertypeResolver (Closed)

Created:
8 years, 9 months ago by scheglov

Modified:
8 years, 9 months ago

Reviewers:
zundel

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use NodeElement in SupertypeResolver Use Element.getNameLocation() in TopLevelElementBuilder R=zundel@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=5475

Patch Set 1 #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -15 lines)			Patch
M	compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java	View	2 chunks	+6 lines, -13 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/TypeVariableElementImplementation.java	View	1 chunk	+1 line, -1 line	0 comments	Download
A	compiler/java/com/google/dart/compiler/resolver/TypeVariableNodeElement.java	View	1 chunk	+13 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

zundel

8 years, 9 months ago (2012-03-14 17:13:03 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/9699030/diff/1/compiler/java/com/googl...
File
compiler/java/com/google/dart/compiler/resolver/TypeVariableNodeElement.java
(right):

https://chromiumcodereview.appspot.com/9699030/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/resolver/TypeVariableNodeElement.java:1:
// Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
date

Expand Messages | Collapse Messages