Issue 9695057: Allow "const ... native" constructors and "const factory ... native" constructors in dartc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9695057: Allow "const ... native" constructors and "const factory ... native" constructors in dartc (Closed)

Created:
8 years, 9 months ago by zundel

Modified:
8 years, 9 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Allow "const ... native" constructors and "const factory ... native" constructors in dartc These are used in the VM and frog core library implementations. Committed: https://code.google.com/p/dart/source/detail?r=5428

Patch Set 1 : # #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -9 lines)			Patch
	M	compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java	View		4 chunks	+15 lines, -8 lines	2 comments	Download
	M	frog/lib/date_implementation.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

zundel

Apparently the VM team has had a request to add this to the spec and ...

8 years, 9 months ago (2012-03-13 18:44:28 UTC) #1

scheglov

LGTM https://chromiumcodereview.appspot.com/9695057/diff/7/compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java File compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java (right): https://chromiumcodereview.appspot.com/9695057/diff/7/compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java#newcode479 compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java:479: if (dartBlock != null && !(dartBlock instanceof DartNativeBlock)) ...

8 years, 9 months ago (2012-03-13 19:07:09 UTC) #2

zundel

8 years, 9 months ago (2012-03-13 19:21:09 UTC) #3

https://chromiumcodereview.appspot.com/9695057/diff/7/compiler/java/com/googl...
File compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java (right):

https://chromiumcodereview.appspot.com/9695057/diff/7/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java:479: if
(dartBlock != null && !(dartBlock instanceof DartNativeBlock)) {
On 2012/03/13 19:07:09, scheglov wrote:
> Just formally repeat here offline discussion.
> What if "dartBlock" is null?
> We will not show error in this case.

Done.

Expand Messages | Collapse Messages