Template parser

More changes for CSS to run under VM.

Need unique name for library collision with template parser.


Few more changes to work under VM.


More changes for lang.dart seperation.


Seperation from lang.dart (tokenizer can't access private fields of base class in another library).  This was allowed in frog but not in the VM.  VM is right so need to sever dependency.


BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=5544

[Siggi Cherem (dart-lang), 2012-03-15 01:21:25]

some initial drive-by comments, mostly nitpicks. I can take a closer look when I
get back...

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/css/css
File utils/css/css (right):

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/css/css#newcode20
utils/css/css:20: $BASE_DIR/../../frog/minfrog --libdir=$BASE_DIR/../../frog/lib
$BASE_DIR/tool.dart $SRCFILE $OUTPUT
switch to run tool.dart directly in the vm?

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/css/cssoptions...
File utils/css/cssoptions.dart (right):

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/css/cssoptions...
utils/css/cssoptions.dart:14: // TODO(sigmund): make into a generic option
parser...
what did I do?

:) - remove the TODO since this is copied from frog?

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/css/treebase.dart
File utils/css/treebase.dart (right):

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/css/treebase.d...
utils/css/treebase.dart:7: class ASTNode {
there is a lot of code copied from the parser in frog (here, tokenizer, etc). It
would be nice if some of this code could be shared... consult with jim/john for
ideas?

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/css/treebase.d...
utils/css/treebase.dart:26: // TODO(terry): Should be abstract class but frog
doesn't support abstract class keyword yet.
80 col (here and below)

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/css/uitest.dart
File utils/css/uitest.dart (right):

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/css/uitest.dar...
utils/css/uitest.dart:9: // TODO(terry): Remove use for debug only.
agree (and the call in line 50)

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/template/codeg...
File utils/template/codegen.dart (right):

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/template/codeg...
utils/template/codegen.dart:5: // TODO(terry): Remove use for debug only.
same here

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/template/codeg...
utils/template/codegen.dart:69: /*
delete?

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/template/codeg...
utils/template/codegen.dart:78: /* Returns mixed list of elements marked with
the var attribute.  If the
add extra line so that the comment is always as follows:
/**
 * multi-line comment.
 */

or
 /** one-line comment. */

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/template/codeg...
utils/template/codegen.dart:100: // List of statement constructors for each var
inside a #each.
switch to use the same kind of comments here too (like above)

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/template/codeg...
utils/template/codegen.dart:209: /* Emiting the following code fragment where
varName is the attribute
I think we normally use // comments within code, and only /* */ for dartdoc
comments.

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/template/codeg...
utils/template/codegen.dart:234:
statement.add("');\r${spaces}${parentName}.elements.add(${varName});\r");
80 col, here and several below in this file

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/template/sourc...
File utils/template/source.dart (right):

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/template/sourc...
utils/template/source.dart:9: class SourceFile implements Comparable {
looks like you should be able to share this file and some other files from frog
using a #source. At least maybe share between css/ and template/?

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/template/template
File utils/template/template (right):

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/template/templ...
utils/template/template:71: DART_VM="$BASE_DIR/../../out/Debug_ia32/dart"
I recommend using Release_ia32 instead, and pass in the flags:
--enable_type_checks --enable_asserts?

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/tests/template...
File utils/tests/template/README.txt (right):

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/tests/template...
utils/tests/template/README.txt:6: name_entry2.tmpl     - simple template
expression inside bunch of nested tags
80 col...

[terry, 2012-03-15 19:02:48]

Thanks Siggi.  See comments inline.

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/css/css
File utils/css/css (right):

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/css/css#newcode20
utils/css/css:20: $BASE_DIR/../../frog/minfrog --libdir=$BASE_DIR/../../frog/lib
$BASE_DIR/tool.dart $SRCFILE $OUTPUT
On 2012/03/15 01:21:25, sigmund wrote:
> switch to run tool.dart directly in the vm?

Done.

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/css/cssoptions...
File utils/css/cssoptions.dart (right):

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/css/cssoptions...
utils/css/cssoptions.dart:14: // TODO(sigmund): make into a generic option
parser...
On 2012/03/15 01:21:25, sigmund wrote:
> what did I do?
> 
> :) - remove the TODO since this is copied from frog?

Done.

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/css/treebase.dart
File utils/css/treebase.dart (right):

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/css/treebase.d...
utils/css/treebase.dart:7: class ASTNode {
Since frog will be going away I didn't want to rely on code in lang library. 
I've moved replicated code to both CSS and the template parser.  I'll be
refactoring to a tokenizing utility library that will be shared by both css and
template. 
On 2012/03/15 01:21:25, sigmund wrote:
> there is a lot of code copied from the parser in frog (here, tokenizer, etc).
It
> would be nice if some of this code could be shared... consult with jim/john
for
> ideas?

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/css/treebase.d...
utils/css/treebase.dart:26: // TODO(terry): Should be abstract class but frog
doesn't support abstract class keyword yet.
On 2012/03/15 01:21:25, sigmund wrote:
> 80 col (here and below)

Done.

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/css/uitest.dart
File utils/css/uitest.dart (right):

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/css/uitest.dar...
utils/css/uitest.dart:9: // TODO(terry): Remove use for debug only.
On 2012/03/15 01:21:25, sigmund wrote:
> agree (and the call in line 50)

Done.

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/template/codeg...
File utils/template/codegen.dart (right):

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/template/codeg...
utils/template/codegen.dart:69: /*
On 2012/03/15 01:21:25, sigmund wrote:
> delete?

Done.

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/template/codeg...
utils/template/codegen.dart:100: // List of statement constructors for each var
inside a #each.
On 2012/03/15 01:21:25, sigmund wrote:
> switch to use the same kind of comments here too (like above)

Done.

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/template/codeg...
utils/template/codegen.dart:234:
statement.add("');\r${spaces}${parentName}.elements.add(${varName});\r");
On 2012/03/15 01:21:25, sigmund wrote:
> 80 col, here and several below in this file

Done.

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/template/sourc...
File utils/template/source.dart (right):

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/template/sourc...
utils/template/source.dart:9: class SourceFile implements Comparable {
Yes, see earlier comment on common tokenizer library for css/template.
On 2012/03/15 01:21:25, sigmund wrote:
> looks like you should be able to share this file and some other files from
frog
> using a #source. At least maybe share between css/ and template/?

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/template/template
File utils/template/template (right):

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/template/templ...
utils/template/template:71: DART_VM="$BASE_DIR/../../out/Debug_ia32/dart"
I've removed DART_VM and use just dart ...

DartDoc/ApiDoc both assume dart VM is on the $PATH so I assume the same.
On 2012/03/15 01:21:25, sigmund wrote:
> I recommend using Release_ia32 instead, and pass in the flags:
> --enable_type_checks --enable_asserts?

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/tests/template...
File utils/tests/template/README.txt (right):

https://chromiumcodereview.appspot.com/9695048/diff/8037/utils/tests/template...
utils/tests/template/README.txt:6: name_entry2.tmpl     - simple template
expression inside bunch of nested tags
On 2012/03/15 01:21:25, sigmund wrote:
> 80 col...

Done.