Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 9694024: - Allow string interpolation in constant strings. (Closed)

Created:
8 years, 9 months ago by Ivan Posva
Modified:
8 years, 9 months ago
Reviewers:
kasperl, hausner
CC:
reviews_dartlang.org, zundel, Kasper Lund
Visibility:
Public.

Description

- Allow string interpolation in constant strings. - Add test for constant adjacent strings with and without interpolation. - Update status files. Committed: https://code.google.com/p/dart/source/detail?r=5377

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -21 lines) Patch
M runtime/vm/parser.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language.status View 3 chunks +3 lines, -0 lines 0 comments Download
M tests/language/language-leg.status View 1 chunk +2 lines, -1 line 0 comments Download
A tests/language/src/AdjacentConstStringLiteralsTest.dart View 1 1 chunk +96 lines, -0 lines 2 comments Download
D tests/language/src/StringInterpolation7NegativeTest.dart View 1 chunk +0 lines, -14 lines 0 comments Download
A + tests/language/src/StringInterpolation8Test.dart View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ivan Posva
8 years, 9 months ago (2012-03-13 00:25:53 UTC) #1
zundel
Are there any tests for the type of the interpolated expression being limited to int, ...
8 years, 9 months ago (2012-03-13 00:55:29 UTC) #2
hausner
lgtm LGTM.
8 years, 9 months ago (2012-03-13 00:56:07 UTC) #3
Ivan Posva
On 2012/03/13 00:55:29, zundel wrote: > Are there any tests for the type of the ...
8 years, 9 months ago (2012-03-13 00:57:53 UTC) #4
kasperl
8 years, 9 months ago (2012-03-13 08:32:23 UTC) #5
https://chromiumcodereview.appspot.com/9694024/diff/3001/tests/language/src/A...
File tests/language/src/AdjacentConstStringLiteralsTest.dart (right):

https://chromiumcodereview.appspot.com/9694024/diff/3001/tests/language/src/A...
tests/language/src/AdjacentConstStringLiteralsTest.dart:11: toString() {
=>

Powered by Google App Engine
This is Rietveld 408576698