Issue 9693044: Increase timeout limit when running on VM --enable_type_checks.

Issue 9693044: Increase timeout limit when running on VM --enable_type_checks. (Closed)

Created:
8 years, 9 months ago by ahe

Modified:
8 years, 9 months ago

Reviewers:
ricow1, Emily Fortuna, ngeoffray, kasperl, floitsch

CC:
reviews_dartlang.org, compiler-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Increase timeout limit when running on VM --enable_type_checks. Also, build from the dart directory, not frog. Committed: https://code.google.com/p/dart/source/detail?r=5414

Patch Set 1 #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -21 lines)			Patch
	M	dart/frog/scripts/buildbot_annotated_steps.py	View		4 chunks	+17 lines, -15 lines	2 comments	Download
	M	dart/tests/co19/co19-leg.status	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

ahe

FYI: I have tested the changes locally, and it seems to work.

8 years, 9 months ago (2012-03-13 15:56:46 UTC) #2

Emily Fortuna

lgtm! https://chromiumcodereview.appspot.com/9693044/diff/1/dart/frog/scripts/buildbot_annotated_steps.py File dart/frog/scripts/buildbot_annotated_steps.py (right): https://chromiumcodereview.appspot.com/9693044/diff/1/dart/frog/scripts/buildbot_annotated_steps.py#newcode91 dart/frog/scripts/buildbot_annotated_steps.py:91: print 'running %s' % (' '.join(cmd)) Do we ...

8 years, 9 months ago (2012-03-13 17:11:32 UTC) #6

ahe

8 years, 9 months ago (2012-03-14 07:26:26 UTC) #8

https://chromiumcodereview.appspot.com/9693044/diff/1/dart/frog/scripts/build...
File dart/frog/scripts/buildbot_annotated_steps.py (right):

https://chromiumcodereview.appspot.com/9693044/diff/1/dart/frog/scripts/build...
dart/frog/scripts/buildbot_annotated_steps.py:91: print 'running %s' % ('
'.join(cmd))
On 2012/03/13 17:11:32, Emily Fortuna wrote:
> Do we want this print statement here?

I think we do. I have heard complaints that it is hard to figure out what our
build bots are doing. This is an attempt to make it easier.

Expand Messages | Collapse Messages