Issue 9692044: Parameter adapter name in setter should be 'value'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9692044: Parameter adapter name in setter should be 'value'. (Closed)

Created:
8 years, 9 months ago by podivilov

Modified:
8 years, 9 months ago

Reviewers:
sra, Anton Muhin, antonm, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Parameter adapter name in setter should be 'value'. R=antonm@chromium.org,sra@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=5453

Patch Set 1 #

Total comments: 3

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -25 lines)			Patch
	M	client/dom/scripts/systemnative.py	View		7 chunks	+13 lines, -25 lines	3 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

podivilov

http://codereview.chromium.org/9692044/diff/1/client/dom/scripts/systemnative.py File client/dom/scripts/systemnative.py (left): http://codereview.chromium.org/9692044/diff/1/client/dom/scripts/systemnative.py#oldcode292 client/dom/scripts/systemnative.py:292: cpp_arg_name = CppSafeName(arg.id) c++ keywords are never used as ...

8 years, 9 months ago (2012-03-13 12:48:13 UTC) #2

lgtm

Expand Messages | Collapse Messages