Unresolved super-send is not a compile-time error.

Unresolved super-send is not a compile-time error.

Committed: https://code.google.com/p/dart/source/detail?r=5386

[kasperl, 2012-03-13 08:55:30]

LGTM.

https://chromiumcodereview.appspot.com/9692018/diff/1/dart/frog/leg/compiler....
File dart/frog/leg/compiler.dart (right):

https://chromiumcodereview.appspot.com/9692018/diff/1/dart/frog/leg/compiler....
dart/frog/leg/compiler.dart:379: Math.max((end.next !== null) ?
end.next.charOffset : 0, startOffset + 1);
It's a bit hard to read and understand this line now.

https://chromiumcodereview.appspot.com/9692018/diff/1/dart/frog/leg/resolver....
File dart/frog/leg/resolver.dart (right):

https://chromiumcodereview.appspot.com/9692018/diff/1/dart/frog/leg/resolver....
dart/frog/leg/resolver.dart:732: // It is OK for target to be null, it means
invoking
Maybe rephrase: That target can be null which means we'll invoke noSuchMethod on
super.

[ahe, 2012-03-13 09:12:11]

Hi Kasper,

Thank you for your suggestions.

Cheers,
Peter

https://chromiumcodereview.appspot.com/9692018/diff/1/dart/frog/leg/compiler....
File dart/frog/leg/compiler.dart (right):

https://chromiumcodereview.appspot.com/9692018/diff/1/dart/frog/leg/compiler....
dart/frog/leg/compiler.dart:379: Math.max((end.next !== null) ?
end.next.charOffset : 0, startOffset + 1);
On 2012/03/13 08:55:30, kasperl wrote:
> It's a bit hard to read and understand this line now.
>    

Done.

https://chromiumcodereview.appspot.com/9692018/diff/1/dart/frog/leg/resolver....
File dart/frog/leg/resolver.dart (right):

https://chromiumcodereview.appspot.com/9692018/diff/1/dart/frog/leg/resolver....
dart/frog/leg/resolver.dart:732: // It is OK for target to be null, it means
invoking
On 2012/03/13 08:55:30, kasperl wrote:
> Maybe rephrase: That target can be null which means we'll invoke noSuchMethod
on
> super.

Done.

[ahe, 2012-03-13 09:12:12]

Hi Kasper,

Thank you for your suggestions.

Cheers,
Peter

[ngeoffray, 2012-03-13 11:32:30]

LGTM

https://chromiumcodereview.appspot.com/9692018/diff/5001/dart/frog/leg/resolv...
File dart/frog/leg/resolver.dart (right):

https://chromiumcodereview.appspot.com/9692018/diff/5001/dart/frog/leg/resolv...
dart/frog/leg/resolver.dart:733: // super.
No warning?