Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 9692006: Remove AST dumps, useless for Editor (Closed)

Created:
8 years, 9 months ago by scheglov
Modified:
8 years, 9 months ago
Reviewers:
zundel, Brian Wilkerson
CC:
reviews_dartlang.org, danrubel
Visibility:
Public.

Description

Patch Set 1 #

Messages

Total messages: 6 (0 generated)
scheglov
8 years, 9 months ago (2012-03-12 19:22:13 UTC) #1
Brian Wilkerson
LGTM, unless Eric has an objection to removing these.
8 years, 9 months ago (2012-03-12 19:27:29 UTC) #2
zundel
I asked if these are getting in the way, but I don't remember seeing the ...
8 years, 9 months ago (2012-03-12 19:39:33 UTC) #3
scheglov
On 2012/03/12 19:39:33, zundel wrote: > I asked if these are getting in the way, ...
8 years, 9 months ago (2012-03-12 20:21:46 UTC) #4
zundel
Its OK with me now if we remove these libraries, since we are committed to ...
8 years, 9 months ago (2012-03-28 15:52:04 UTC) #5
zundel
8 years, 9 months ago (2012-03-28 15:52:14 UTC) #6
On 2012/03/28 15:52:04, zundel wrote:
> Its OK with me now if we remove these libraries, since we are committed to
> replacing the current code with a new AST anyway.

LGTM

Powered by Google App Engine
This is Rietveld 408576698