Issue 9691045: By popular demand, print the configurations being tested by test.dart at startup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9691045: By popular demand, print the configurations being tested by test.dart at startup. (Closed)

Created:
8 years, 9 months ago by Mads Ager (google)

Modified:
8 years, 9 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

By popular demand, print the configurations being tested by test.dart at startup. This time don't print anything if the 'silent' progress is requested. Question to be answered later: Do we actually need the JUnit tests? What do they add? R=whesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=5403

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -0 lines)			Patch
M	tools/test.dart	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
M	tools/test-compiler.dart	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
M	tools/test-runtime.dart	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

lgtm https://chromiumcodereview.appspot.com/9691045/diff/1/tools/test-compiler.dart File tools/test-compiler.dart (right): https://chromiumcodereview.appspot.com/9691045/diff/1/tools/test-compiler.dart#newcode34 tools/test-compiler.dart:34: if (configurations.every((conf) => conf['progress'] != 'silent')) { The ...

8 years, 9 months ago (2012-03-13 14:15:39 UTC) #2

Mads Ager (google)

8 years, 9 months ago (2012-03-13 14:17:47 UTC) #3

https://chromiumcodereview.appspot.com/9691045/diff/1/tools/test-compiler.dart
File tools/test-compiler.dart (right):

https://chromiumcodereview.appspot.com/9691045/diff/1/tools/test-compiler.dar...
tools/test-compiler.dart:34: if (configurations.every((conf) => conf['progress']
!= 'silent')) {
On 2012/03/13 14:15:39, Bill Hesse wrote:
> The .every seems like overkill.  But it works.  Every configuration has the
same
> 'progress' value.

You are right. I have moved it below the extraction of global options and just
test that 'progressIndicator != "silent"'. Thanks.

Expand Messages | Collapse Messages