Issue 9689086: Fixes cyclic constructor issue in dartc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9689086: Fixes cyclic constructor issue in dartc (Closed)

Created:
8 years, 9 months ago by zundel

Modified:
8 years, 9 months ago

Reviewers:
ericzundel, ahe, Brian Wilkerson

CC:
reviews_dartlang.org, ahe

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixes cyclic constructor issue in dartc I moved leg's test into language since the same test replicated the problem. Committed: https://code.google.com/p/dart/source/detail?r=5447

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -17 lines)			Patch
M	compiler/java/com/google/dart/compiler/resolver/Resolver.java	View	2 chunks	+7 lines, -1 line	0 comments	Download
D	frog/tests/leg_only/src/CyclicConstructorTest.dart	View	1 chunk	+0 lines, -17 lines	0 comments	Download
A +	tests/language/src/CyclicConstructorTest.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

8 years, 9 months ago (2012-03-14 07:18:36 UTC) #3

LGTM, thank you for moving the test to the shared location. I don't know why we
have leg_only, now that I think about it.

I'll discuss with the team if we should promote them all to language.

Expand Messages | Collapse Messages