Visit Node in CompileTimeConstantAnalyzer only if Node based

Visit Node in CompileTimeConstantAnalyzer only if Node based
...in other case expect that FieldElement will return type from getConstantType().



R=zundel@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=5425

[zundel, 2012-03-13 17:10:34]

lgtm

offline discussion is that when serializing, we will either provide a new
implementation of the Elements, or will do a custom serializer so as to not save
the node references.

https://chromiumcodereview.appspot.com/9689063/diff/1/compiler/java/com/googl...
File
compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java
(right):

https://chromiumcodereview.appspot.com/9689063/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java:509:
((HasConstantTypeSetter) node.getElement()).setConstantType(type);
It seems awkward that you need a cast here.

https://chromiumcodereview.appspot.com/9689063/diff/1/compiler/java/com/googl...
File compiler/java/com/google/dart/compiler/resolver/HasConstantTypeSetter.java
(right):

https://chromiumcodereview.appspot.com/9689063/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/resolver/HasConstantTypeSetter.java:1: //
Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
2012