Issue 9689059: By popular demand, print the configurations being tested by test.dart at startup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9689059: By popular demand, print the configurations being tested by test.dart at startup. (Closed)

Created:
8 years, 9 months ago by Mads Ager (google)

Modified:
8 years, 9 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

By popular demand, print the configurations being tested by test.dart at startup. R=whesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=5393

Patch Set 2 : Address comment. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -0 lines)			Patch
M	tools/test.dart	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	tools/test-compiler.dart	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	tools/test-runtime.dart	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

LGTM. https://chromiumcodereview.appspot.com/9689059/diff/1/tools/test-compiler.dart File tools/test-compiler.dart (right): https://chromiumcodereview.appspot.com/9689059/diff/1/tools/test-compiler.dart#newcode31 tools/test-compiler.dart:31: StringBuffer sb = new StringBuffer('Test configuration(s):'); 'Test configuration${configurations.length ...

8 years, 9 months ago (2012-03-13 12:28:23 UTC) #2

Mads Ager (google)

8 years, 9 months ago (2012-03-13 12:34:47 UTC) #3

https://chromiumcodereview.appspot.com/9689059/diff/1/tools/test-compiler.dart
File tools/test-compiler.dart (right):

https://chromiumcodereview.appspot.com/9689059/diff/1/tools/test-compiler.dar...
tools/test-compiler.dart:31: StringBuffer sb = new StringBuffer('Test
configuration(s):');
On 2012/03/13 12:28:24, Bill Hesse wrote:
> 'Test configuration${configurations.length > 1 ? "s" : ""}' ?

Sure, I can do that. :)

Expand Messages | Collapse Messages

Issue 9689059: By popular demand, print the configurations being tested by test.dart at startup. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comment. #

Messages