Issue 9688016: Hack around aborting loop body.

Issue 9688016: Hack around aborting loop body. (Closed)

Created:
8 years, 9 months ago by ahe

Modified:
8 years, 9 months ago

Reviewers:
floitsch, ngeoffray

CC:
reviews_dartlang.org, compiler-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Hack around aborting loop body. Committed: https://code.google.com/p/dart/source/detail?r=5337

Patch Set 2 : Address review comments #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -41 lines)			Patch
M	dart/frog/leg/ssa/builder.dart	View	1	5 chunks	+17 lines, -19 lines	0 comments	Download
M	dart/frog/tests/leg/leg.status	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	dart/tests/co19/co19-leg.status	View		6 chunks	+5 lines, -15 lines	0 comments	Download
M	dart/tests/language/language-leg.status	View		4 chunks	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM as a temporary solution. https://chromiumcodereview.appspot.com/9688016/diff/1/dart/frog/leg/ssa/builder.dart File dart/frog/leg/ssa/builder.dart (right): https://chromiumcodereview.appspot.com/9688016/diff/1/dart/frog/leg/ssa/builder.dart#newcode2486 dart/frog/leg/ssa/builder.dart:2486: if (isAborted()) { Add ...

8 years, 9 months ago (2012-03-12 15:48:24 UTC) #2

ahe

Thank you, Florian! Cheers, Peter https://chromiumcodereview.appspot.com/9688016/diff/1/dart/frog/leg/ssa/builder.dart File dart/frog/leg/ssa/builder.dart (right): https://chromiumcodereview.appspot.com/9688016/diff/1/dart/frog/leg/ssa/builder.dart#newcode2486 dart/frog/leg/ssa/builder.dart:2486: if (isAborted()) { On ...

8 years, 9 months ago (2012-03-12 16:55:34 UTC) #3

LGTM!

Expand Messages | Collapse Messages