Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 968053004: Allow command-line API to pass in selection to preserve. Fix #194. (Closed)

Created:
5 years, 9 months ago by Bob Nystrom
Modified:
5 years, 9 months ago
Reviewers:
pquitslund
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dart_style.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow command-line API to pass in selection to preserve. Fix #194. R=pquitslund@google.com Committed: 8f8eee47dc1c0776a96b2564db06eafefe13f966

Patch Set 1 #

Patch Set 2 : Update version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -38 lines) Patch
M CHANGELOG.md View 1 1 chunk +4 lines, -0 lines 0 comments Download
M bin/format.dart View 7 chunks +60 lines, -23 lines 0 comments Download
M lib/src/formatter_options.dart View 4 chunks +14 lines, -9 lines 0 comments Download
M lib/src/io.dart View 2 chunks +6 lines, -5 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M test/command_line_test.dart View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Bob Nystrom
I changed the syntax a bit. Instead of: -s 1,2 Now, it's: --preserve 1:2 I ...
5 years, 9 months ago (2015-03-03 02:00:41 UTC) #2
pquitslund
On 2015/03/03 02:00:41, Bob Nystrom wrote: > I changed the syntax a bit. Instead of: ...
5 years, 9 months ago (2015-03-03 03:20:08 UTC) #3
pquitslund
LGTM. Thanks for jumping on this. Sorry I didn't catch it earlier. :/
5 years, 9 months ago (2015-03-03 03:20:31 UTC) #4
Bob Nystrom
5 years, 9 months ago (2015-03-03 17:22:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8f8eee47dc1c0776a96b2564db06eafefe13f966 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698