Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 9677062: Step 1: Introduce a new method for source objects that will replace the current getUri (Closed)

Created:
8 years, 9 months ago by Brian Wilkerson
Modified:
8 years, 9 months ago
Reviewers:
scheglov, zundel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Step 1: Introduce a new method for source objects that will replace the current getUri Committed: https://code.google.com/p/dart/source/detail?r=5440

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -83 lines) Patch
M compiler/java/com/google/dart/compiler/DartCompiler.java View 1 chunk +5 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/DefaultLibrarySource.java View 1 chunk +5 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/DeltaAnalyzer.java View 1 chunk +5 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/Source.java View 1 chunk +7 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/UrlSource.java View 1 chunk +5 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/testing/TestLibrarySource.java View 2 chunks +10 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/util/DartSourceString.java View 1 chunk +9 lines, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/MockBundleLibrarySource.java View 1 chunk +5 lines, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/SourceTest.java View 1 chunk +5 lines, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/MemoryLibrarySource.java View 1 chunk +5 lines, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/parser/LibraryParserTest.java View 1 chunk +5 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerUtilities.java View 27 chunks +101 lines, -80 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerWarmup.java View 3 chunks +8 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/compiler/TestDartSource.java View 1 chunk +5 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/compiler/TestLibrarySource.java View 1 chunk +5 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/completion/MockSource.java View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Brian Wilkerson
8 years, 9 months ago (2012-03-13 20:00:34 UTC) #1
scheglov
LGTM
8 years, 9 months ago (2012-03-13 20:12:44 UTC) #2
zundel
8 years, 9 months ago (2012-03-13 20:37:43 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698