Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 9677056: Add git svn support to create_graph.py. (Closed)

Created:
8 years, 9 months ago by vsm
Modified:
8 years, 9 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add git svn support to create_graph.py. This lets git users test locally. Committed: https://code.google.com/p/dart/source/detail?r=5426

Patch Set 1 #

Total comments: 1

Patch Set 2 : Some cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M tools/testing/perf_testing/create_graph.py View 1 2 chunks +13 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
vsm
8 years, 9 months ago (2012-03-13 18:14:58 UTC) #1
Emily Fortuna
lgtm, see comment, please https://chromiumcodereview.appspot.com/9677056/diff/1/tools/testing/perf_testing/create_graph.py File tools/testing/perf_testing/create_graph.py (right): https://chromiumcodereview.appspot.com/9677056/diff/1/tools/testing/perf_testing/create_graph.py#newcode293 tools/testing/perf_testing/create_graph.py:293: run_cmd(['echo', line.strip()], outfile) This is ...
8 years, 9 months ago (2012-03-13 18:18:04 UTC) #2
vsm
PTAL
8 years, 9 months ago (2012-03-13 18:34:36 UTC) #3
Emily Fortuna
8 years, 9 months ago (2012-03-13 18:35:15 UTC) #4
I like it. LGTM!

Powered by Google App Engine
This is Rietveld 408576698