Issue 9677007: Fix build breakage caused from revision 5341 in Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9677007: Fix build breakage caused from revision 5341 in Windows. (Closed)

Created:
8 years, 9 months ago by Emily Fortuna

Modified:
8 years, 9 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix build breakage caused from revision 5341 in Windows. TBR: whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=5355

Patch Set 1 #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/testing/dart/test_suite.dart	View		1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

LGTM. https://chromiumcodereview.appspot.com/9677007/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://chromiumcodereview.appspot.com/9677007/diff/1/tools/testing/dart/test_suite.dart#newcode701 tools/testing/dart/test_suite.dart:701: .replaceAll('\\', '_') + configuration['component'] + '.html'; OK, but ...

8 years, 9 months ago (2012-03-13 00:26:22 UTC) #2

Emily Fortuna

8 years, 9 months ago (2012-03-13 00:33:51 UTC) #3

https://chromiumcodereview.appspot.com/9677007/diff/1/tools/testing/dart/test...
File tools/testing/dart/test_suite.dart (right):

https://chromiumcodereview.appspot.com/9677007/diff/1/tools/testing/dart/test...
tools/testing/dart/test_suite.dart:701: .replaceAll('\\', '_') +
configuration['component'] + '.html';
On 2012/03/13 00:26:22, Bill Hesse wrote:
> OK, but I don't know why we don't fix filename when we first get it, rather
than
> fixing it at many different later places.  I'll fix this someday.

I'm fine with fixing it initially -- it's just all the Windows bots were broken
at the time, and I needed to get a fix in quickly before more tests broke.

Expand Messages | Collapse Messages