Issue 9669016: - Support "no_" as well as "no-" prefix on boolean flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9669016: - Support "no_" as well as "no-" prefix on boolean flags. (Closed)

Created:
8 years, 9 months ago by Ivan Posva

Modified:
8 years, 9 months ago

Reviewers:
regis, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

- Support "no_" as well as "no-" prefix on boolean flags. Committed: https://code.google.com/p/dart/source/detail?r=5270

Patch Set 1 #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
	M	vm/flags.cc	View		1 chunk	+9 lines, -4 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

https://chromiumcodereview.appspot.com/9669016/diff/1/vm/flags.cc File vm/flags.cc (right): https://chromiumcodereview.appspot.com/9669016/diff/1/vm/flags.cc#newcode198 vm/flags.cc:198: Normalize(name); Would it not work if this normalization block ...

8 years, 9 months ago (2012-03-10 00:19:48 UTC) #3

Ivan Posva

8 years, 9 months ago (2012-03-10 00:31:30 UTC) #4

https://chromiumcodereview.appspot.com/9669016/diff/1/vm/flags.cc
File vm/flags.cc (right):

https://chromiumcodereview.appspot.com/9669016/diff/1/vm/flags.cc#newcode198
vm/flags.cc:198: Normalize(name);
On 2012/03/10 00:19:49, asiva wrote:
> Would it not work if this normalization block is moved above and a if
> (strncmp(name, kNoPrefix....) is done?

That would work too, but then you have to ensure to not normalize the parameters
to string flags.

Expand Messages | Collapse Messages