Issue 9669011: BoolTest passes in checked mode (throws TypeError-s correctly). Fix buildbot.

Issue 9669011: BoolTest passes in checked mode (throws TypeError-s correctly). Fix buildbot. (Closed)

Created:
8 years, 9 months ago by srdjan

Modified:
8 years, 9 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

BoolTest passes in checked mode (throws TypeError-s correctly). Fix buildbot. Committed: https://code.google.com/p/dart/source/detail?r=5252

Patch Set 2 : #

Total comments: 3

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	tests/language/language.status	View		1 chunk	+3 lines, -1 line	3 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/9669011/diff/3001/tests/language/language.status File tests/language/language.status (right): https://chromiumcodereview.appspot.com/9669011/diff/3001/tests/language/language.status#newcode236 tests/language/language.status:236: I think there was already a section below ...

8 years, 9 months ago (2012-03-09 21:40:25 UTC) #2

srdjan

https://chromiumcodereview.appspot.com/9669011/diff/3001/tests/language/language.status File tests/language/language.status (right): https://chromiumcodereview.appspot.com/9669011/diff/3001/tests/language/language.status#newcode439 tests/language/language.status:439: PrivateMemberTest/01: Fail # test seems bad - see issue ...

8 years, 9 months ago (2012-03-09 22:17:18 UTC) #3

regis

8 years, 9 months ago (2012-03-09 22:20:54 UTC) #4

Got it. Thanks.


On 2012/03/09 22:17:18, srdjan wrote:
>
https://chromiumcodereview.appspot.com/9669011/diff/3001/tests/language/langu...
> File tests/language/language.status (right):
> 
>
https://chromiumcodereview.appspot.com/9669011/diff/3001/tests/language/langu...
> tests/language/language.status:439: PrivateMemberTest/01: Fail # test seems
bad
> - see issue #353
> On 2012/03/09 21:40:26, regis wrote:
> > Here
> 
> It is missing webdriver

Expand Messages | Collapse Messages