Issue 9669007: Added logical op tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9669007: Added logical op tests. (Closed)

Created:
8 years, 9 months ago by srdjan

Modified:
8 years, 9 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Added logical op tests. Committed: https://code.google.com/p/dart/source/detail?r=5249

Patch Set 2 : #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -0 lines)			Patch
	M	tests/language/language.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	tests/language/src/BoolTest.dart	View		1 chunk	+89 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/9669007/diff/2001/tests/language/src/BoolTest.dart File tests/language/src/BoolTest.dart (right): https://chromiumcodereview.appspot.com/9669007/diff/2001/tests/language/src/BoolTest.dart#newcode172 tests/language/src/BoolTest.dart:172: It would be easier to read if the ...

8 years, 9 months ago (2012-03-09 20:48:27 UTC) #2

srdjan

8 years, 9 months ago (2012-03-09 21:14:55 UTC) #3

https://chromiumcodereview.appspot.com/9669007/diff/2001/tests/language/src/B...
File tests/language/src/BoolTest.dart (right):

https://chromiumcodereview.appspot.com/9669007/diff/2001/tests/language/src/B...
tests/language/src/BoolTest.dart:172: 
On 2012/03/09 20:48:27, regis wrote:
> It would be easier to read if the counts were reset between the tests instead
of
> being cumulative.
> trueCount = 0;
> falseCount = 0;

Done.

Expand Messages | Collapse Messages

Issue 9669007: Added logical op tests. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages