Add get_drt.py to test.dart, so that testing browser components updates DumpRenderTree.

Add get_drt.py to test.dart, so that testing browser components updates DumpRenderTree.


BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=5341

[Bill Hesse, 2012-03-12 13:38:32]

http://codereview.chromium.org/9666053/diff/1/tools/testing/dart/drt_updater....
File tools/testing/dart/drt_updater.dart (right):

http://codereview.chromium.org/9666053/diff/1/tools/testing/dart/drt_updater....
tools/testing/dart/drt_updater.dart:44: // blah blah blah
Remove Bob Loblaw.

[Mads Ager (google), 2012-03-12 14:09:20]

LGTM with minor comments.

http://codereview.chromium.org/9666053/diff/1/tools/testing/dart/drt_updater....
File tools/testing/dart/drt_updater.dart (right):

http://codereview.chromium.org/9666053/diff/1/tools/testing/dart/drt_updater....
tools/testing/dart/drt_updater.dart:14: static Process updatingProcess;
Make this private?

http://codereview.chromium.org/9666053/diff/1/tools/testing/dart/drt_updater....
tools/testing/dart/drt_updater.dart:31: const <String>['dartium',
return TestUtils.isBrowserComponent(component)?

http://codereview.chromium.org/9666053/diff/1/tools/testing/dart/drt_updater....
tools/testing/dart/drt_updater.dart:37: static String get getDrtPath() {
Make this private?

http://codereview.chromium.org/9666053/diff/1/tools/testing/dart/drt_updater....
tools/testing/dart/drt_updater.dart:43: static void onUpdatedHandler(int
exit_code) {
Make this private.

http://codereview.chromium.org/9666053/diff/1/tools/testing/dart/drt_updater....
tools/testing/dart/drt_updater.dart:45: print('DumpRenderTree
updated($exit_code)');
Space between "updated" and "($exit_code)"?

http://codereview.chromium.org/9666053/diff/1/tools/testing/dart/drt_updater....
tools/testing/dart/drt_updater.dart:46: for (var callback in onUpdated )
callback();
Remove trailing space after onUpdated.

[vsm, 2012-03-12 15:53:21]

DBC

Thanks for doing this!

http://codereview.chromium.org/9666053/diff/1/tools/testing/dart/drt_updater....
File tools/testing/dart/drt_updater.dart (right):

http://codereview.chromium.org/9666053/diff/1/tools/testing/dart/drt_updater....
tools/testing/dart/drt_updater.dart:35: 'webdriver'].some((x) => x ==
component);
webdriver shouldn't need DRT.  It'll use chrome (or another browser) instead.

[Bill Hesse, 2012-03-12 16:18:55]

'chromium' is being removed, as well.

On 2012/03/12 15:53:21, vsm wrote:
> DBC
> 
> Thanks for doing this!
> 
>
http://codereview.chromium.org/9666053/diff/1/tools/testing/dart/drt_updater....
> File tools/testing/dart/drt_updater.dart (right):
> 
>
http://codereview.chromium.org/9666053/diff/1/tools/testing/dart/drt_updater....
> tools/testing/dart/drt_updater.dart:35: 'webdriver'].some((x) => x ==
> component);
> webdriver shouldn't need DRT.  It'll use chrome (or another browser) instead.

[Bill Hesse, 2012-03-12 18:13:34]

http://codereview.chromium.org/9666053/diff/1/tools/testing/dart/drt_updater....
File tools/testing/dart/drt_updater.dart (right):

http://codereview.chromium.org/9666053/diff/1/tools/testing/dart/drt_updater....
tools/testing/dart/drt_updater.dart:14: static Process updatingProcess;
On 2012/03/12 14:09:20, Mads Ager wrote:
> Make this private?

Done.

http://codereview.chromium.org/9666053/diff/1/tools/testing/dart/drt_updater....
tools/testing/dart/drt_updater.dart:31: const <String>['dartium',
On 2012/03/12 14:09:20, Mads Ager wrote:
> return TestUtils.isBrowserComponent(component)?

This is an open question - should these be assumed to have the same semantics? 
In which case, which library should import the other?  This will be a circular
dependency, while this way drt_updater has no dependency on anything.  I'll
change this later, if you want.


And now, after the changes, they are different: webdriver is a browser test, but
not a DRT test.

http://codereview.chromium.org/9666053/diff/1/tools/testing/dart/drt_updater....
tools/testing/dart/drt_updater.dart:35: 'webdriver'].some((x) => x ==
component);
On 2012/03/12 15:53:21, vsm wrote:
> webdriver shouldn't need DRT.  It'll use chrome (or another browser) instead.

Done.

http://codereview.chromium.org/9666053/diff/1/tools/testing/dart/drt_updater....
tools/testing/dart/drt_updater.dart:37: static String get getDrtPath() {
On 2012/03/12 14:09:20, Mads Ager wrote:
> Make this private?

Done.

http://codereview.chromium.org/9666053/diff/1/tools/testing/dart/drt_updater....
tools/testing/dart/drt_updater.dart:43: static void onUpdatedHandler(int
exit_code) {
On 2012/03/12 14:09:20, Mads Ager wrote:
> Make this private.

Done.

http://codereview.chromium.org/9666053/diff/1/tools/testing/dart/drt_updater....
tools/testing/dart/drt_updater.dart:44: // blah blah blah
On 2012/03/12 13:38:32, Bill Hesse wrote:
> Remove Bob Loblaw.

Done.

http://codereview.chromium.org/9666053/diff/1/tools/testing/dart/drt_updater....
tools/testing/dart/drt_updater.dart:45: print('DumpRenderTree
updated($exit_code)');
On 2012/03/12 14:09:20, Mads Ager wrote:
> Space between "updated" and "($exit_code)"?

Done.

http://codereview.chromium.org/9666053/diff/1/tools/testing/dart/drt_updater....
tools/testing/dart/drt_updater.dart:46: for (var callback in onUpdated )
callback();
On 2012/03/12 14:09:20, Mads Ager wrote:
> Remove trailing space after onUpdated.

Done.