Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 9666006: Support for "a is Function". (Closed)

Created:
8 years, 9 months ago by ngeoffray
Modified:
8 years, 9 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, karlklose, Lasse Reichstein Nielsen, floitsch, kasperl
Visibility:
Public.

Description

Support for "a is Function". Committed: https://code.google.com/p/dart/source/detail?r=5322

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -90 lines) Patch
M frog/leg/compiler.dart View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
M frog/leg/emitter.dart View 1 7 chunks +28 lines, -25 lines 0 comments Download
M frog/leg/enqueue.dart View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M frog/leg/lib/js_helper.dart View 1 2 2 chunks +12 lines, -4 lines 0 comments Download
M frog/leg/ssa/closure.dart View 1 2 2 chunks +11 lines, -8 lines 0 comments Download
M frog/leg/ssa/codegen.dart View 1 3 chunks +26 lines, -4 lines 0 comments Download
M frog/tests/leg/src/mock_compiler.dart View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download
M tests/co19/co19-leg.status View 1 2 3 2 chunks +0 lines, -5 lines 0 comments Download
M tests/language/language-leg.status View 1 2 3 3 chunks +0 lines, -3 lines 0 comments Download
A tests/language/src/FunctionGetterTest.dart View 1 1 chunk +11 lines, -0 lines 0 comments Download
A + tests/language/src/IsFunctionTest.dart View 2 chunks +28 lines, -40 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ngeoffray
8 years, 9 months ago (2012-03-09 18:01:44 UTC) #1
ngeoffray
PTAL, I have updated the emitter as discussed.
8 years, 9 months ago (2012-03-12 12:29:58 UTC) #2
ngeoffray
PTAAL
8 years, 9 months ago (2012-03-12 12:52:35 UTC) #3
floitsch
8 years, 9 months ago (2012-03-12 13:04:38 UTC) #4
LGTM!
thanks.

Powered by Google App Engine
This is Rietveld 408576698