Issue 9665029: Generate code for instance of: copy from CodeGenerator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9665029: Generate code for instance of: copy from CodeGenerator. (Closed)

Created:
8 years, 9 months ago by srdjan

Modified:
8 years, 9 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Generate code for instance of: copy from CodeGenerator. More code needed for the instantiator "thing" Committed: https://code.google.com/p/dart/source/detail?r=5329

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+186 lines, -1 line)			Patch
M	runtime/vm/flow_graph_compiler_x64.h	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 2	2 chunks	+177 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Kevin Millikin (Google)

8 years, 9 months ago (2012-03-12 14:01:17 UTC) #2

LGTM, sort of rubber-stampish on the copied code.