Base test case of a multi-test now insists no static type warnings

Base test case of a multi-test now insists no static type warnings

There were 5 multitests that need adjustment after this change. 4 of them
were trivial changes, so I went ahead and fixed them.

http://code.google.com/p/dart/issues/detail?id=2107

Committed: https://code.google.com/p/dart/source/detail?r=5350

[zundel, 2012-03-12 14:54:38]

https://chromiumcodereview.appspot.com/9664065/diff/1009/tests/language/src/T...
File tests/language/src/TypeVariableBounds2Test.dart (right):

https://chromiumcodereview.appspot.com/9664065/diff/1009/tests/language/src/T...
tests/language/src/TypeVariableBounds2Test.dart:12: extends num /// 00:
continued
This test required a bit of hacking.  The multiple 'continued' lines are to get
the static type warning out of the 'none' case.    Also, the 'continued' line
was expected to occur after the first annotation, so I had to change the logic
in multitest.dart to accommodate putting the 'continued' annotation first.

[Bill Hesse, 2012-03-12 16:02:49]

LGTM.

http://codereview.chromium.org/9664065/diff/1009/tests/language/src/TypeVaria...
File tests/language/src/TypeVariableBounds2Test.dart (right):

http://codereview.chromium.org/9664065/diff/1009/tests/language/src/TypeVaria...
tests/language/src/TypeVariableBounds2Test.dart:35: // In both production and
checked modes, A<String> is a subtype of I.
subtype of J, not I.

http://codereview.chromium.org/9664065/diff/1009/tests/language/src/TypeVaria...
tests/language/src/TypeVariableBounds2Test.dart:62: 
Extra line.

http://codereview.chromium.org/9664065/diff/1009/tools/testing/dart/multitest...
File tools/testing/dart/multitest.dart (right):

http://codereview.chromium.org/9664065/diff/1009/tools/testing/dart/multitest...
tools/testing/dart/multitest.dart:104: "Invalid test directive '$nextOutcome' on
line ${lineCount}: ${annotation.rest} ");
Line too long?
I think they have put concatenation of two adjacent strings in - is it in the
VM?

http://codereview.chromium.org/9664065/diff/1009/tools/testing/dart/multitest...
tools/testing/dart/multitest.dart:119: if (outcomes[outcomeKey].isEmpty()) {
Why not: if outcomeKey != 'none' && outcomes[outcomeKey].isEmpty()

http://codereview.chromium.org/9664065/diff/1009/tools/testing/dart/multitest...
tools/testing/dart/multitest.dart:120: Expect.fail("Test ${outcomeKey} has no
valid annotated outcomes. Expected one of:
${validMultitestOutcomes.toString()}");
Long line.

http://codereview.chromium.org/9664065/diff/1009/tools/testing/dart/multitest...
tools/testing/dart/multitest.dart:149: annotation.outcomesList =
annotation.rest.split(',');
annotation.outcomesList = annotation.rest.split(',').map((e)=>e.trim());

or maybe map(String.trim)?  I don't know if that works.  probably not.

Or a local function: Function trim(String e) => e.trim();
parts = line.split .... .map(trim)
outcomesList = .... .split(',').map(trim);

[zundel, 2012-03-12 20:06:23]

https://chromiumcodereview.appspot.com/9664065/diff/1009/tools/testing/dart/m...
File tools/testing/dart/multitest.dart (right):

https://chromiumcodereview.appspot.com/9664065/diff/1009/tools/testing/dart/m...
tools/testing/dart/multitest.dart:104: "Invalid test directive '$nextOutcome' on
line ${lineCount}: ${annotation.rest} ");
On 2012/03/12 16:02:49, Bill Hesse wrote:
> Line too long?
> I think they have put concatenation of two adjacent strings in - is it in the
> VM?

Looks like we need to update the dart executable tools/testing/vm/<os> to get
it.

https://chromiumcodereview.appspot.com/9664065/diff/1009/tools/testing/dart/m...
tools/testing/dart/multitest.dart:119: if (outcomes[outcomeKey].isEmpty()) {
On 2012/03/12 16:02:49, Bill Hesse wrote:
> Why not: if outcomeKey != 'none' && outcomes[outcomeKey].isEmpty()

Done.