- Fix use of String operator + in language and corelib tests.

- Fix use of String operator + in language and corelib tests.
Committed: https://code.google.com/p/dart/source/detail?r=6415

[Ivan Posva, 2012-03-12 05:55:10]

Please check that the meaning of the tests has not changed. After this change
there are still 3 tests that rely on String.+ in language, but some of them rely
on mixing ints and Strings. So I want to get in touch with the test authors
before fixing them.

-Ivan

[kasperl, 2012-03-12 06:55:42]

LGTM. I think we should be careful not to add too many uses of concat.

https://chromiumcodereview.appspot.com/9664052/diff/1/tests/corelib/src/RegEx...
File tests/corelib/src/RegExpAllMatchesTest.dart (right):

https://chromiumcodereview.appspot.com/9664052/diff/1/tests/corelib/src/RegEx...
tests/corelib/src/RegExpAllMatchesTest.dart:43: var mapped = matches.map((Match
m) => m.group(0).concat("bar"));
I'd suggest using string interpolation here:

   => "${m.group(0)}bar"

https://chromiumcodereview.appspot.com/9664052/diff/1/tests/language/src/Call...
File tests/language/src/CallThroughGetterTest.dart (right):

https://chromiumcodereview.appspot.com/9664052/diff/1/tests/language/src/Call...
tests/language/src/CallThroughGetterTest.dart:158: _mark(m) { _order =
_order.concat(m); return _order; }
This would be cleaner with a string buffer, but I understand if you don't want
to mess too much with this test.

Pretty sure something like:

   _order.add(m); return _order.toString()

would work fine if you change _order to a StringBuffer.

https://chromiumcodereview.appspot.com/9664052/diff/1/tests/language/src/Expe...
File tests/language/src/ExpectTest.dart (right):

https://chromiumcodereview.appspot.com/9664052/diff/1/tests/language/src/Expe...
tests/language/src/ExpectTest.dart:15: Expect.equals("AB", a.concat("B"));
String interpolation?

https://chromiumcodereview.appspot.com/9664052/diff/1/tests/language/src/Expe...
tests/language/src/ExpectTest.dart:42: var ab = a.concat("B");
String interpolation?

https://chromiumcodereview.appspot.com/9664052/diff/1/tests/language/src/Inte...
File tests/language/src/InterfaceFactoryMultiTest.dart (right):

https://chromiumcodereview.appspot.com/9664052/diff/1/tests/language/src/Inte...
tests/language/src/InterfaceFactoryMultiTest.dart:17: AImpl(String one, String
two) : _secret = one.concat(two);
_secret = "${one}${two}"

https://chromiumcodereview.appspot.com/9664052/diff/1/tests/language/src/Inte...
tests/language/src/InterfaceFactoryMultiTest.dart:31: BImpl(String one, String
two) : _secret = two.concat(one);
_secret = "${two}${one}"

https://chromiumcodereview.appspot.com/9664052/diff/1/tests/language/src/Inte...
File tests/language/src/InterfaceFactoryTest.dart (right):

https://chromiumcodereview.appspot.com/9664052/diff/1/tests/language/src/Inte...
tests/language/src/InterfaceFactoryTest.dart:45: SomeImplementation(String one,
String two) : _secret = one.concat(two) {}
_secret = "${one}${two}"

[Ivan Posva, 2012-04-11 14:26:00]

https://chromiumcodereview.appspot.com/9664052/diff/1/tests/corelib/src/RegEx...
File tests/corelib/src/RegExpAllMatchesTest.dart (right):

https://chromiumcodereview.appspot.com/9664052/diff/1/tests/corelib/src/RegEx...
tests/corelib/src/RegExpAllMatchesTest.dart:43: var mapped = matches.map((Match
m) => m.group(0).concat("bar"));
On 2012/03/12 06:55:42, kasperl wrote:
> I'd suggest using string interpolation here:
> 
>    => "${m.group(0)}bar"

Done.

https://chromiumcodereview.appspot.com/9664052/diff/1/tests/language/src/Call...
File tests/language/src/CallThroughGetterTest.dart (right):

https://chromiumcodereview.appspot.com/9664052/diff/1/tests/language/src/Call...
tests/language/src/CallThroughGetterTest.dart:158: _mark(m) { _order =
_order.concat(m); return _order; }
On 2012/03/12 06:55:42, kasperl wrote:
> This would be cleaner with a string buffer, but I understand if you don't want
> to mess too much with this test.
> 
> Pretty sure something like:
> 
>    _order.add(m); return _order.toString()
> 
> would work fine if you change _order to a StringBuffer.

Done.

https://chromiumcodereview.appspot.com/9664052/diff/1/tests/language/src/Expe...
File tests/language/src/ExpectTest.dart (right):

https://chromiumcodereview.appspot.com/9664052/diff/1/tests/language/src/Expe...
tests/language/src/ExpectTest.dart:15: Expect.equals("AB", a.concat("B"));
On 2012/03/12 06:55:42, kasperl wrote:
> String interpolation?

Done.

https://chromiumcodereview.appspot.com/9664052/diff/1/tests/language/src/Expe...
tests/language/src/ExpectTest.dart:42: var ab = a.concat("B");
On 2012/03/12 06:55:42, kasperl wrote:
> String interpolation?

Done.

https://chromiumcodereview.appspot.com/9664052/diff/1/tests/language/src/Inte...
File tests/language/src/InterfaceFactoryMultiTest.dart (right):

https://chromiumcodereview.appspot.com/9664052/diff/1/tests/language/src/Inte...
tests/language/src/InterfaceFactoryMultiTest.dart:17: AImpl(String one, String
two) : _secret = one.concat(two);
On 2012/03/12 06:55:42, kasperl wrote:
> _secret = "${one}${two}"

Done.

https://chromiumcodereview.appspot.com/9664052/diff/1/tests/language/src/Inte...
tests/language/src/InterfaceFactoryMultiTest.dart:31: BImpl(String one, String
two) : _secret = two.concat(one);
On 2012/03/12 06:55:42, kasperl wrote:
> _secret = "${two}${one}"

Done.

https://chromiumcodereview.appspot.com/9664052/diff/1/tests/language/src/Inte...
File tests/language/src/InterfaceFactoryTest.dart (right):

https://chromiumcodereview.appspot.com/9664052/diff/1/tests/language/src/Inte...
tests/language/src/InterfaceFactoryTest.dart:45: SomeImplementation(String one,
String two) : _secret = one.concat(two) {}
On 2012/03/12 06:55:42, kasperl wrote:
> _secret = "${one}${two}"

Done.