Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 9664040: Update status file. (Closed)

Created:
8 years, 9 months ago by floitsch
Modified:
8 years, 9 months ago
Reviewers:
ahe, Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/language/language.status View 1 chunk +1 line, -1 line 4 comments Download

Messages

Total messages: 5 (0 generated)
floitsch
TBR
8 years, 9 months ago (2012-03-11 01:01:01 UTC) #1
ahe
LGTM https://chromiumcodereview.appspot.com/9664040/diff/1/tests/language/language.status File tests/language/language.status (right): https://chromiumcodereview.appspot.com/9664040/diff/1/tests/language/language.status#newcode419 tests/language/language.status:419: [ $component == webdriver && $browser == ff ...
8 years, 9 months ago (2012-03-11 10:36:00 UTC) #2
floitsch
https://chromiumcodereview.appspot.com/9664040/diff/1/tests/language/language.status File tests/language/language.status (right): https://chromiumcodereview.appspot.com/9664040/diff/1/tests/language/language.status#newcode419 tests/language/language.status:419: [ $component == webdriver && $browser == ff && ...
8 years, 9 months ago (2012-03-11 14:23:56 UTC) #3
ahe
https://chromiumcodereview.appspot.com/9664040/diff/1/tests/language/language.status File tests/language/language.status (right): https://chromiumcodereview.appspot.com/9664040/diff/1/tests/language/language.status#newcode419 tests/language/language.status:419: [ $component == webdriver && $browser == ff && ...
8 years, 9 months ago (2012-03-11 14:33:50 UTC) #4
Emily Fortuna
8 years, 9 months ago (2012-03-13 00:21:42 UTC) #5
https://chromiumcodereview.appspot.com/9664040/diff/1/tests/language/language...
File tests/language/language.status (right):

https://chromiumcodereview.appspot.com/9664040/diff/1/tests/language/language...
tests/language/language.status:419: [ $component == webdriver && $browser == ff
&& $system == win32 ]
On 2012/03/11 14:33:51, ahe wrote:
> On 2012/03/11 14:23:56, floitsch wrote:
> > On 2012/03/11 10:36:00, ahe wrote:
> > > Oops. I didn't notice that.
> > 
> > copied from line 430.
> > Should we change it there too?
> 
> Good question. Let's ask Emily.

win32 is the correct form. There are a couple of places where the tag is
incorrectly named (like 430). Feel free to change those too.

Powered by Google App Engine
This is Rietveld 408576698