Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 9664029: Fix type check to perform a subtype test at top level instead of an (Closed)

Created:
8 years, 9 months ago by regis
Modified:
8 years, 9 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix type check to perform a subtype test at top level instead of an assignability test. This only makes a difference when assigning an instance of a function type. Fix a bad language test. Disable a bad co19 test (issue 99 filed). Change error message for dynamic type error. Committed: https://code.google.com/p/dart/source/detail?r=5413

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -273 lines) Patch
M runtime/lib/error.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/code_generator.cc View 1 6 chunks +17 lines, -12 lines 0 comments Download
M runtime/vm/exceptions.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/object.h View 1 10 chunks +9 lines, -107 lines 0 comments Download
M runtime/vm/object.cc View 1 13 chunks +47 lines, -136 lines 0 comments Download
M runtime/vm/parser.cc View 1 4 chunks +14 lines, -10 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/src/NamedParametersTypeTest.dart View 1 2 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
regis
8 years, 9 months ago (2012-03-10 00:56:41 UTC) #1
srdjan
8 years, 9 months ago (2012-03-12 18:40:02 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698