Issue 9664004: Annotates some more tests for static type warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9664004: Annotates some more tests for static type warnings (Closed)

Created:
8 years, 9 months ago by zundel

Modified:
8 years, 9 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Annotates some more tests for static type warnings Committed: https://code.google.com/p/dart/source/detail?r=5247

Patch Set 1 #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -24 lines)			Patch
M	tests/language/src/CallThroughGetterTest.dart	View	1 chunk	+2 lines, -2 lines	1 comment	Download
M	tests/language/src/DefaultImplementation2Test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/src/DynamicFieldTest.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	tests/language/src/Factory2Test.dart	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	tests/language/src/InterfaceFactoryTest.dart	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	tests/language/src/InterfaceTest.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/src/Issue1363Test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/src/MapLiteral3Test.dart	View	3 chunks	+6 lines, -5 lines	0 comments	Download
M	tests/language/src/NamedParameters2Test.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

zundel

https://chromiumcodereview.appspot.com/9664004/diff/1/tests/language/src/CallThroughGetterTest.dart File tests/language/src/CallThroughGetterTest.dart (right): https://chromiumcodereview.appspot.com/9664004/diff/1/tests/language/src/CallThroughGetterTest.dart#newcode32 tests/language/src/CallThroughGetterTest.dart:32: TOP_LEVEL_CONST(); /// static type warning oops, forgot to change ...

8 years, 9 months ago (2012-03-09 17:05:47 UTC) #1

LGTM

Expand Messages | Collapse Messages