Issue 9663065: Fix ConstructorRedirectTest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9663065: Fix ConstructorRedirectTest. (Closed)

Created:
8 years, 9 months ago by ahe

Modified:
8 years, 9 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix ConstructorRedirectTest. Committed: https://code.google.com/p/dart/source/detail?r=5326

Patch Set 2 : Add commetn #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -1 line)			Patch
M	dart/tests/language/language.status	View		3 chunks	+4 lines, -0 lines	0 comments	Download
M	dart/tests/language/language-leg.status	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	dart/tests/language/src/ConstructorRedirectTest.dart	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM! https://chromiumcodereview.appspot.com/9663065/diff/1/dart/tests/language/src/ConstructorRedirectTest.dart File dart/tests/language/src/ConstructorRedirectTest.dart (right): https://chromiumcodereview.appspot.com/9663065/diff/1/dart/tests/language/src/ConstructorRedirectTest.dart#newcode12 dart/tests/language/src/ConstructorRedirectTest.dart:12: static Maybe add a comment that explain why ...

8 years, 9 months ago (2012-03-12 12:14:36 UTC) #2

ahe

8 years, 9 months ago (2012-03-12 15:48:28 UTC) #3

Thanks, Kasper.

https://chromiumcodereview.appspot.com/9663065/diff/1/dart/tests/language/src...
File dart/tests/language/src/ConstructorRedirectTest.dart (right):

https://chromiumcodereview.appspot.com/9663065/diff/1/dart/tests/language/src...
dart/tests/language/src/ConstructorRedirectTest.dart:12: static
On 2012/03/12 12:14:36, kasperl wrote:
> Maybe add a comment that explain why this works?

Done.

Expand Messages | Collapse Messages

Issue 9663065: Fix ConstructorRedirectTest. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add commetn #

Messages