Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 9662065: Revert stray edit to test.dart. (Closed)

Created:
8 years, 9 months ago by Bill Hesse
Modified:
8 years, 9 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert stray edit to test.dart. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=5387

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/testing/dart/test_runner.dart View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 5 (0 generated)
Bill Hesse
This doesn't seem to turn the buildbot red - maybe you want to look into ...
8 years, 9 months ago (2012-03-12 17:32:22 UTC) #1
Emily Fortuna
On 2012/03/12 17:32:22, Bill Hesse wrote: > This doesn't seem to turn the buildbot red ...
8 years, 9 months ago (2012-03-12 19:47:23 UTC) #2
Emily Fortuna
On 2012/03/12 17:32:22, Bill Hesse wrote: > This doesn't seem to turn the buildbot red ...
8 years, 9 months ago (2012-03-12 19:47:30 UTC) #3
Bill Hesse
No, I mean this error (accidental commit) doesn't seem to break anything. I thing the ...
8 years, 9 months ago (2012-03-13 00:21:41 UTC) #4
Emily Fortuna
8 years, 9 months ago (2012-03-13 00:30:31 UTC) #5
https://chromiumcodereview.appspot.com/9662065/diff/1/tools/testing/dart/test...
File tools/testing/dart/test_runner.dart (right):

https://chromiumcodereview.appspot.com/9662065/diff/1/tools/testing/dart/test...
tools/testing/dart/test_runner.dart:1017: if (const
RegExp(@"selenium-server-standalone-.*\.jar").hasMatch(file)
But if we add the @ character, we'd be using a raw string that doesn't have any
escape characters, but the \ in this line is used as an escape character. See
http://www.dartlang.org/docs/spec/dartLangSpec.pdf page 40.

Powered by Google App Engine
This is Rietveld 408576698