Fix some type and logical errors in test.dart, found by the Dart editor.

Fix some type and logical errors in test.dart, found by the Dart editor.


BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=5334

[zundel, 2012-03-12 15:35:27]

http://codereview.chromium.org/9662063/diff/1/tools/testing/dart/test_runner....
File tools/testing/dart/test_runner.dart (right):

http://codereview.chromium.org/9662063/diff/1/tools/testing/dart/test_runner....
tools/testing/dart/test_runner.dart:279: for (String line in super.stderr) {
This is really tricky, overriding a field/getter in the superclass with a
different type.  I believe that is supposed to cause a type error as well.  I
think it would be better to rename one of the fields.

[zundel, 2012-03-12 16:40:19]

lgtm

http://codereview.chromium.org/9662063/diff/1/tools/testing/dart/test_runner....
File tools/testing/dart/test_runner.dart (right):

http://codereview.chromium.org/9662063/diff/1/tools/testing/dart/test_runner....
tools/testing/dart/test_runner.dart:279: for (String line in super.stderr) {
On 2012/03/12 15:35:27, zundel wrote:
> This is really tricky, overriding a field/getter in the superclass with a
> different type.  I believe that is supposed to cause a type error as well.  I
> think it would be better to rename one of the fields.

Nm, this isn't the problem I thought it was.  I hit 'F3' and th editor took me
back to the wrong stderr.

[Bill Hesse, 2012-03-12 17:28:10]

https://chromiumcodereview.appspot.com/9662063/diff/1/tools/testing/dart/test...
File tools/testing/dart/test_runner.dart (right):

https://chromiumcodereview.appspot.com/9662063/diff/1/tools/testing/dart/test...
tools/testing/dart/test_runner.dart:279: for (String line in super.stderr) {
This class and the superclass are supposed to have the same types for stderr. 
I'm just trying to avoid the top level OutputStream stderr from dart:io. 
Inherited names are weaker than global scope names.

Otherwise, we can change all of these to stderrLines.


On 2012/03/12 15:35:27, zundel wrote:
> This is really tricky, overriding a field/getter in the superclass with a
> different type.  I believe that is supposed to cause a type error as well.  I
> think it would be better to rename one of the fields.

https://chromiumcodereview.appspot.com/9662063/diff/1/tools/testing/dart/test...
tools/testing/dart/test_runner.dart:1017: if (const
RegExp("selenium-server-standalone-.*\.jar").hasMatch(file)
This is a stray typo.

This accidentally made it into the commit.  Will be reverted.