Issue 9662038: Unbreak web tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9662038: Unbreak web tests. (Closed)

Created:
8 years, 9 months ago by ngeoffray

Modified:
8 years, 9 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Unbreak web tests. Committed: https://code.google.com/p/dart/source/detail?r=5288

Patch Set 1 #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	tests/language/src/GetterSetterInLibTest.dart	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ahe

8 years, 9 months ago (2012-03-10 22:13:42 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/9662038/diff/1/tests/language/src/Gett...
File tests/language/src/GetterSetterInLibTest.dart (right):

https://chromiumcodereview.appspot.com/9662038/diff/1/tests/language/src/Gett...
tests/language/src/GetterSetterInLibTest.dart:5:
#library('GetterSetterInLibTest');
I think this is wrong. We need to fix the web tests.

Expand Messages | Collapse Messages