Issue 9662037: Compile time constants with fields.

Issue 9662037: Compile time constants with fields. (Closed)

Created:
8 years, 9 months ago by floitsch

Modified:
8 years, 9 months ago

Reviewers:
karlklose, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Compile time constants with fields. Committed: https://code.google.com/p/dart/source/detail?r=5323

Patch Set 2 : Propagate definitions to inits. #

Patch Set 4 : Address comments. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+174 lines, -57 lines)			Patch
M	frog/leg/compile_time_constants.dart	View	1 2 3	7 chunks	+134 lines, -53 lines	0 comments	Download
M	tests/co19/co19-leg.status	View	1 2 3	2 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/language/language.status	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/language/language-leg.status	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
A	tests/language/src/CompileTimeConstantDTest.dart	View	1 2 3	1 chunk	+36 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://chromiumcodereview.appspot.com/9662037/diff/5/frog/leg/compile_time_constants.dart File frog/leg/compile_time_constants.dart (right): https://chromiumcodereview.appspot.com/9662037/diff/5/frog/leg/compile_time_constants.dart#newcode785 frog/leg/compile_time_constants.dart:785: if (definitions === null) error(send); What does it ...

8 years, 9 months ago (2012-03-12 14:02:53 UTC) #2

floitsch

8 years, 9 months ago (2012-03-12 14:37:52 UTC) #3

https://chromiumcodereview.appspot.com/9662037/diff/5/frog/leg/compile_time_c...
File frog/leg/compile_time_constants.dart (right):

https://chromiumcodereview.appspot.com/9662037/diff/5/frog/leg/compile_time_c...
frog/leg/compile_time_constants.dart:785: if (definitions === null) error(send);
On 2012/03/12 14:02:53, ngeoffray wrote:
> What does it mean to not have a definitions? Not being in a function context?
> Could you somehow abstract that?

Done.

https://chromiumcodereview.appspot.com/9662037/diff/5/frog/leg/compile_time_c...
frog/leg/compile_time_constants.dart:891: arguments = const [];
On 2012/03/12 14:02:53, ngeoffray wrote:
> const <Constant>[];

Done.

https://chromiumcodereview.appspot.com/9662037/diff/5/frog/leg/compile_time_c...
frog/leg/compile_time_constants.dart:893: arguments = [];
On 2012/03/12 14:02:53, ngeoffray wrote:
> <Constant>[];

Done.

Expand Messages | Collapse Messages