When importing a library without a prefix, add the elements from the element map instead of the lis…

When importing a library without a prefix, add the elements from the element map instead of the list of elements. The element map contains the abstract fields, whereas the list of elements contain the getter and the setter.
Committed: https://code.google.com/p/dart/source/detail?r=5287

[ahe, 2012-03-10 19:45:41]

https://chromiumcodereview.appspot.com/9662035/diff/1/frog/leg/scanner/scanne...
File frog/leg/scanner/scanner_task.dart (right):

https://chromiumcodereview.appspot.com/9662035/diff/1/frog/leg/scanner/scanne...
frog/leg/scanner/scanner_task.dart:108: imported.elements.forEach((SourceString
_, Element element) {
I think this would lead to re-exporting imported elements.

I suggest that you add a forEachExport to library:

forEachExport(f(Element element)) {
  elements.forEach((_, e) {
    if (this === e.getLibrary()) f(e);
  });
}

[ngeoffray, 2012-03-10 20:57:31]

PTAL

https://chromiumcodereview.appspot.com/9662035/diff/1/frog/leg/scanner/scanne...
File frog/leg/scanner/scanner_task.dart (right):

https://chromiumcodereview.appspot.com/9662035/diff/1/frog/leg/scanner/scanne...
frog/leg/scanner/scanner_task.dart:108: imported.elements.forEach((SourceString
_, Element element) {
On 2012/03/10 19:45:41, ahe wrote:
> I think this would lead to re-exporting imported elements.
> 
> I suggest that you add a forEachExport to library:
> 
> forEachExport(f(Element element)) {
>   elements.forEach((_, e) {
>     if (this === e.getLibrary()) f(e);
>   });
> }

Good point. Done.

[ahe, 2012-03-10 20:58:48]

LGTM!

https://chromiumcodereview.appspot.com/9662035/diff/1004/frog/leg/elements/el...
File frog/leg/elements/elements.dart (right):

https://chromiumcodereview.appspot.com/9662035/diff/1004/frog/leg/elements/el...
frog/leg/elements/elements.dart:281: if (this == e.getLibrary()) f(e);
===

[ngeoffray, 2012-03-10 20:58:56]

Thanks Peter, PTAL

[ngeoffray, 2012-03-10 20:59:34]

On 2012/03/10 20:58:56, ngeoffray wrote:
> Thanks Peter, PTAL

You replied too fast! :) Thanks Peter.

[ngeoffray, 2012-03-10 21:21:27]

PTAL, I had to change forEachExport after presubmit failures.

[ahe, 2012-03-10 21:26:36]

LGTM

https://chromiumcodereview.appspot.com/9662035/diff/5/frog/leg/elements/eleme...
File frog/leg/elements/elements.dart (right):

https://chromiumcodereview.appspot.com/9662035/diff/5/frog/leg/elements/eleme...
frog/leg/elements/elements.dart:263: print(existing);
debug code?

https://chromiumcodereview.appspot.com/9662035/diff/5/frog/leg/elements/eleme...
frog/leg/elements/elements.dart:264: print(element);
ditto

https://chromiumcodereview.appspot.com/9662035/diff/5/frog/leg/elements/eleme...
frog/leg/elements/elements.dart:284: && e.kind !== ElementKind.PREFIX
See the code above in lookupLocalMember. Shouldn't it have the same fix?

[ngeoffray, 2012-03-10 21:30:50]

https://chromiumcodereview.appspot.com/9662035/diff/5/frog/leg/elements/eleme...
File frog/leg/elements/elements.dart (right):

https://chromiumcodereview.appspot.com/9662035/diff/5/frog/leg/elements/eleme...
frog/leg/elements/elements.dart:263: print(existing);
On 2012/03/10 21:26:36, ahe wrote:
> debug code?

Done.

https://chromiumcodereview.appspot.com/9662035/diff/5/frog/leg/elements/eleme...
frog/leg/elements/elements.dart:264: print(element);
On 2012/03/10 21:26:36, ahe wrote:
> ditto

Done.

https://chromiumcodereview.appspot.com/9662035/diff/5/frog/leg/elements/eleme...
frog/leg/elements/elements.dart:284: && e.kind !== ElementKind.PREFIX
On 2012/03/10 21:26:36, ahe wrote:
> See the code above in lookupLocalMember. Shouldn't it have the same fix?

Are you referring to the one line 278?
I don't think so. A prefix is a local member that libraries that import the
library should not see. Same for foreign elements.

[ahe, 2012-04-13 13:48:10]

Sorry, forgot to mail this comment.

http://codereview.chromium.org/9662035/diff/5/frog/leg/elements/elements.dart
File frog/leg/elements/elements.dart (right):

http://codereview.chromium.org/9662035/diff/5/frog/leg/elements/elements.dart...
frog/leg/elements/elements.dart:284: && e.kind !== ElementKind.PREFIX
On 2012/03/10 21:30:50, ngeoffray wrote:
> On 2012/03/10 21:26:36, ahe wrote:
> > See the code above in lookupLocalMember. Shouldn't it have the same fix?
> 
> Are you referring to the one line 278?
> I don't think so. A prefix is a local member that libraries that import the
> library should not see. Same for foreign elements.

I was referring to the method above. However, that method is completely broken
and I'm about to remove it. So don't worry about it.