Support for loops without conditions.

Support for loops without conditions.
Committed: https://code.google.com/p/dart/source/detail?r=5222

[Lasse Reichstein Nielsen, 2012-03-09 07:16:46]

LGTM

http://codereview.chromium.org/9657003/diff/1/frog/leg/ssa/builder.dart
File frog/leg/ssa/builder.dart (right):

http://codereview.chromium.org/9657003/diff/1/frog/leg/ssa/builder.dart#newco...
frog/leg/ssa/builder.dart:1080: conditionExitBlock = close(new
HLoopBranch(graph.addConstantBool(true)));
This could be one line with a conditional expression as argument to new
HLoopBranch, or a variable holding just that instruction.

Or, preferably, please add a TODO in the second branch about not making it a
branch when it's unconditional. We could do with just a HGoto, if we make our
loop logic recognize it.

[floitsch, 2012-03-09 08:07:09]

LGTM.

[ngeoffray, 2012-03-09 09:16:44]

Thanks Lasse and Florian,

http://codereview.chromium.org/9657003/diff/1/frog/leg/ssa/builder.dart
File frog/leg/ssa/builder.dart (right):

http://codereview.chromium.org/9657003/diff/1/frog/leg/ssa/builder.dart#newco...
frog/leg/ssa/builder.dart:1080: conditionExitBlock = close(new
HLoopBranch(graph.addConstantBool(true)));
On 2012/03/09 07:16:46, Lasse Reichstein Nielsen wrote:
> This could be one line with a conditional expression as argument to new
> HLoopBranch, or a variable holding just that instruction.
> 

Done.

> Or, preferably, please add a TODO in the second branch about not making it a
> branch when it's unconditional. We could do with just a HGoto, if we make our
> loop logic recognize it.

I added a TODO.