Also create abstract fields for top-level getters and setters.

Also create abstract fields for top-level getters and setters.
Committed: https://code.google.com/p/dart/source/detail?r=5232

[karlklose, 2012-03-09 10:20:54]

LGTM.

https://chromiumcodereview.appspot.com/9655024/diff/1/frog/leg/elements/eleme...
File frog/leg/elements/elements.dart (right):

https://chromiumcodereview.appspot.com/9655024/diff/1/frog/leg/elements/eleme...
frog/leg/elements/elements.dart:162: void handleGetterOrSetter(Element element,
Call it addGetterOrSetter instead?

https://chromiumcodereview.appspot.com/9655024/diff/1/frog/leg/elements/eleme...
frog/leg/elements/elements.dart:167: listener.cancel('duplicate definition of
${name.slowToString()}',
You could extract the error reporting to a local function.

[ahe, 2012-03-09 10:22:07]

Initial comments.

https://chromiumcodereview.appspot.com/9655024/diff/1/frog/leg/elements/eleme...
File frog/leg/elements/elements.dart (right):

https://chromiumcodereview.appspot.com/9655024/diff/1/frog/leg/elements/eleme...
frog/leg/elements/elements.dart:69: ElementCategory.VARIABLE); // TODO(ahe): Sb.
NONE.
I think this can be NONE now.

https://chromiumcodereview.appspot.com/9655024/diff/1/frog/leg/elements/eleme...
frog/leg/elements/elements.dart:72: ElementCategory.VARIABLE); // TODO(ahe): Sb.
NONE.
Ditto.

[ngeoffray, 2012-03-09 13:05:56]

Thanks Peter and Karl

https://chromiumcodereview.appspot.com/9655024/diff/1/frog/leg/elements/eleme...
File frog/leg/elements/elements.dart (right):

https://chromiumcodereview.appspot.com/9655024/diff/1/frog/leg/elements/eleme...
frog/leg/elements/elements.dart:69: ElementCategory.VARIABLE); // TODO(ahe): Sb.
NONE.
On 2012/03/09 10:22:09, ahe wrote:
> I think this can be NONE now.

Done.

https://chromiumcodereview.appspot.com/9655024/diff/1/frog/leg/elements/eleme...
frog/leg/elements/elements.dart:72: ElementCategory.VARIABLE); // TODO(ahe): Sb.
NONE.
On 2012/03/09 10:22:09, ahe wrote:
> Ditto.

Done.

https://chromiumcodereview.appspot.com/9655024/diff/1/frog/leg/elements/eleme...
frog/leg/elements/elements.dart:162: void handleGetterOrSetter(Element element,
On 2012/03/09 10:20:54, karlklose wrote:
> Call it addGetterOrSetter instead?

Done.

https://chromiumcodereview.appspot.com/9655024/diff/1/frog/leg/elements/eleme...
frog/leg/elements/elements.dart:167: listener.cancel('duplicate definition of
${name.slowToString()}',
On 2012/03/09 10:20:54, karlklose wrote:
> You could extract the error reporting to a local function.

Done.

[ngeoffray, 2012-03-09 13:16:33]

PTAL, I had to test whether the existing getter/setter is the one we're trying
to add, to make it work with how we populate library elements.

[karlklose, 2012-03-09 13:19:26]

On 2012/03/09 13:16:33, ngeoffray wrote:
> PTAL, I had to test whether the existing getter/setter is the one we're trying
> to add, to make it work with how we populate library elements.

Still LGTM.