Issue 9655022: Update test expectations to match reality.

Issue 9655022: Update test expectations to match reality. (Closed)

Created:
8 years, 9 months ago by kasperl

Modified:
8 years, 9 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update test expectations to match reality. TBR'ed. R=ngeoffray@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=5218

Patch Set 2 : Crashes in release mode. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -2 lines)			Patch
	M	tests/co19/co19-leg.status	View	1	1 chunk	+8 lines, -1 line	0 comments	Download
	M	tests/language/language.status	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

https://chromiumcodereview.appspot.com/9655022/diff/1/tests/co19/co19-leg.status File tests/co19/co19-leg.status (right): https://chromiumcodereview.appspot.com/9655022/diff/1/tests/co19/co19-leg.status#newcode37 tests/co19/co19-leg.status:37: Language/10_Expressions/01_Constants_A16_t01: Fail # TODO(ahe): Investigate. It actually crashes when ...

8 years, 9 months ago (2012-03-09 08:47:22 UTC) #2

kasperl

8 years, 9 months ago (2012-03-09 08:53:27 UTC) #3

https://chromiumcodereview.appspot.com/9655022/diff/1/tests/co19/co19-leg.status
File tests/co19/co19-leg.status (right):

https://chromiumcodereview.appspot.com/9655022/diff/1/tests/co19/co19-leg.sta...
tests/co19/co19-leg.status:37: Language/10_Expressions/01_Constants_A16_t01:
Fail # TODO(ahe): Investigate.
On 2012/03/09 08:47:22, ngeoffray wrote:
> It actually crashes when the assertions are enabled. I think you need to add
> [ $component == leg && $checked ]
> Language/10_Expressions/01_Constants_A16_t01: Crash

Yeah, I had to update this. Maybe I got it wrong though. It crashes in 'release'
mode, but fails in 'debug' mode. You're probably right that this is a matter of
checked mode versus non-checked mode (and that release runs in checked where
debug does not).

https://chromiumcodereview.appspot.com/9655022/diff/1/tests/language/language...
File tests/language/language.status (right):

https://chromiumcodereview.appspot.com/9655022/diff/1/tests/language/language...
tests/language/language.status:212: AssignStaticTypeTest/04: Fail # Unrecognized
option: --no-enable-type-checks.
On 2012/03/09 08:47:22, ngeoffray wrote:
> Don't they also fail on frog?

I don't think so. I think on frog the parameters are passed in a different order
so the problematic option comes after the --ignore-unrecognized-options flag.

Expand Messages | Collapse Messages