Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 9655015: - The dart:io library uses Uri from dart:uri. (Closed)

Created:
8 years, 9 months ago by Ivan Posva
Modified:
8 years, 9 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

- The dart:io library uses Uri from dart:uri. - Fix the library tag handler to proper import libraries when generating snapshots. Committed: https://code.google.com/p/dart/source/detail?r=5238

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -4 lines) Patch
M bin/gen_snapshot.cc View 1 1 chunk +11 lines, -2 lines 1 comment Download
M bin/io.dart View 1 chunk +1 line, -0 lines 0 comments Download
M bin/main.cc View 1 1 chunk +14 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ivan Posva
Import-what-you-use. -Ivan
8 years, 9 months ago (2012-03-09 01:32:12 UTC) #1
siva
lgtm
8 years, 9 months ago (2012-03-09 01:33:08 UTC) #2
Mads Ager (google)
lgtm
8 years, 9 months ago (2012-03-09 07:00:29 UTC) #3
Ivan Posva
Updated to fix the snapshot generation tag handler. -Ivan
8 years, 9 months ago (2012-03-09 16:45:42 UTC) #4
regis
LGTM
8 years, 9 months ago (2012-03-09 17:05:58 UTC) #5
siva
8 years, 9 months ago (2012-03-09 18:02:38 UTC) #6
https://chromiumcodereview.appspot.com/9655015/diff/4001/bin/gen_snapshot.cc
File bin/gen_snapshot.cc (right):

https://chromiumcodereview.appspot.com/9655015/diff/4001/bin/gen_snapshot.cc#...
bin/gen_snapshot.cc:195: }
The fall through case here is going to produce an incorrect error message. e.g
"import 'dart:xyz'" will result in an "unexpected tag encountered" message.

There should probably be an else here which returns an error message indicating
library not found.

Powered by Google App Engine
This is Rietveld 408576698